fix: add suffix to fluentbit configurator #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslipper
changed the title
We run Kurtosis in our CI pipeline. Multiple processes create Kurtosis enclaves concurrenctly. When the timing is just right, it can lead to a race condition where the fluentbit configurator container sticks around and no further enclaves can be created until we manually delete the fluentbit container. This PR adds a suffix to the configurator container so that it is isolated from other concurrent runs.
mslipper
force-pushed
the
bugfix/fluentd-configurator-name
branch
from
669fd06 to
7071c2e
Compare
|
cc @kurtosis-tech/engineers for review. |
|
Once this is merged, the CI should pass so I'll rerun them. #2572. |
tedim52
approved these changes
Dec 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
🤖 I have created a release *beep* *boop* --- ## [1.4.3](1.4.2...1.4.3) (2024-12-04) ### Bug Fixes * add suffix to fluentbit configurator ([#2567](#2567)) ([f797516](f797516)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
mslipper
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 4, 2024
Kurtosis landed [my fix](kurtosis-tech/kurtosis#2567) for the race condition that prevented us from running a shared Kurtosis instance between jobs. This PR brings that back.
github-merge-queue bot
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 5, 2024
* ci: Remove Kurtosis-specific go job Kurtosis landed [my fix](kurtosis-tech/kurtosis#2567) for the race condition that prevented us from running a shared Kurtosis instance between jobs. This PR brings that back. * remove dep
sigma
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 19, 2024
* ci: Remove Kurtosis-specific go job Kurtosis landed [my fix](kurtosis-tech/kurtosis#2567) for the race condition that prevented us from running a shared Kurtosis instance between jobs. This PR brings that back. * remove dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We run Kurtosis in our CI pipeline. Multiple processes create Kurtosis enclaves concurrenctly. When the timing is just right, it can lead to a race condition where the fluentbit configurator container sticks around and no further enclaves can be created until we manually delete the fluentbit container.
This PR adds a suffix to the configurator container so that it is isolated from other concurrent runs.
Is this change user facing?
No